This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Add dependencies for CPD strict in aspnetcore #9066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
commented
Aug 16, 2020
wtgodbe
suggested changes
Aug 17, 2020
There was a problem hiding this comment.
We should also add System.IO.Pipelines & System.Runtime.CompilerServices.Unsafe, then unpin those in AspNetCore. They're only pinned because of this strict CPD issue: dotnet/aspnetcore#20695
Done. PR should now cover the core-setup portion of dotnet/aspnetcore#24937 and dotnet/aspnetcore#24944 as well as provide what dotnet/aspnetcore needs for strict coherency. |
wtgodbe
approved these changes
Aug 17, 2020
dougbu
added a commit
to dotnet/extensions
that referenced
this pull request
Aug 18, 2020
- aligns with dotnet/core-setup#9066 - unpin System.IO.Pipelines and System.Runtime.CompilerServices.Unsafe Versions - see dotnet/aspnetcore#24937 - move System.IO.Pipelines version to latest
dougbu
added a commit
to dotnet/extensions
that referenced
this pull request
Aug 18, 2020
- aligns with dotnet/core-setup#9066 - unpin System.IO.Pipelines and System.Runtime.CompilerServices.Unsafe Versions - see dotnet/aspnetcore#24937 - move System.IO.Pipelines version to latest
dougbu
added a commit
to dotnet/efcore
that referenced
this pull request
Aug 18, 2020
- aligns with dotnet/core-setup#9066 and dotnet/extensions#3417 - unpin System.IO.Pipelines and System.Runtime.CompilerServices.Unsafe Versions - see dotnet/aspnetcore#24937 - move System.IO.Pipelines version to latest
dougbu
added a commit
to dotnet/efcore
that referenced
this pull request
Aug 18, 2020
* [release/3.1] Add dependencies for CPD strict in aspnetcore - aligns with dotnet/core-setup#9066 and dotnet/extensions#3417 - add Microsoft.Internal.Extensions.Refs dependency too - unpin System.IO.Pipelines and System.Runtime.CompilerServices.Unsafe Versions - see dotnet/aspnetcore#24937 - move System.IO.Pipelines version to latest
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.